Support disk directive in Azure Batch #5120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Talbot <[email protected]>
Signed-off-by: Adam Talbot <[email protected]>
Changes: - Azure calculates autoPool while including resourceDiskSizeGB in the calculation - Determines best fit for VM type using criteria of vCPUs, memory, and resourceDiskSizeGB Signed-off-by: Adam Talbot <[email protected]>
Signed-off-by: Adam Talbot <[email protected]>
Signed-off-by: Adam Talbot <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Adam Talbot <[email protected]>
Signed-off-by: Adam Talbot <[email protected]>
|
If anyone fancies being a rubber duck, I can't work out why the best match for |
adamrtalbot
commented
Jul 8, 2024
plugins/nf-azure/src/test/nextflow/cloud/azure/batch/AzBatchServiceTest.groovy
Outdated
Show resolved
Hide resolved
…rviceTest.groovy Signed-off-by: Adam Talbot <[email protected]>
adamrtalbot
commented
Jul 8, 2024
plugins/nf-azure/src/main/nextflow/cloud/azure/batch/AzBatchService.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Adam Talbot <[email protected]>
Signed-off-by: adamrtalbot <[email protected]>
Adds support for disk directive in Azure Batch tasks by considering disk requirements when calculating VM slots and selecting VM types. Disk requirements are now factored into VM scoring alongside CPU and memory. Modifies the VM scoring algorithm to include disk requirements and weight for CPUs more than memory or disk. Signed-off-by: adamrtalbot <[email protected]>
Signed-off-by: adamrtalbot <[email protected]>
Signed-off-by: adamrtalbot <[email protected]>
Signed-off-by: Adam Talbot <[email protected]>
bentsherman
changed the title
bentsherman
changed the title
|
@bentsherman after many long hours and mental calculations about slots, I've finally finished this one. The only problem I've found is it doesn't account for existing the funnel for cacheing the pool after creation. Not sure how necessary this is but it currently has no awareness of the cpus, memory and disk, just the name. But I wonder if this is indicating I'm missing something? |
adamrtalbot
commented
Dec 9, 2024
Signed-off-by: Adam Talbot <[email protected]>
Signed-off-by: adamrtalbot <[email protected]>
Signed-off-by: adamrtalbot <[email protected]>
Signed-off-by: adamrtalbot <[email protected]>
Changes: - Include the inverse length of the VM name as a modifier for the score - Shorter names are preferred, they have fewer features and are generally cheaper - In doing this, I had to switch from a TreeMap to a List of Tuples because TreeMap was only considering the final set of similar VMs Signed-off-by: adamrtalbot <[email protected]>
Signed-off-by: adamrtalbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
process.diskdirective support to Azure Batch. After adding this directive, Azure Batch will: